Re: a fix for color ls with wrapped lines.

[Jan Engelhardt]

On Wednesday 2008-12-31 13:06, Jim Meyering wrote:
>>
>> You have to use a long filename (not just z.foo) that wraps in the
>> terminal. See the video at
>> http://jengelh.medozas.de/files/coreutils7ls.ogv for details.
>> Version used was v7.0-114-g921feef.
>>
>> Standard ./configure and (slightly abridged) make, as shown.
>
>I see now.
>It doesn't even need to be last, if you run the ls
>command from the "bottom" of the window:

Right, all it needs is a "bgcolor still active" (inside
\e[42m ... \e[0m) and a vertical scroll.

>While the patch produces obviously better output in this case, the resulting
>colorized ls output is always bigger by two bytes per colored file name.
> (it also hard-codes the existing lc+no+rc escapes, which it'd be
>better not to do, since they're user-settable)

I do not have the patch in inbox or sent anymore (it was sent by Alexander
anyway) - was not it three chars - "\e[K"?

        { LEN_STR_PAIR("\e[m\e[K") } /* ec */

>Would one of you care to adjust the patch so the additional escape
>sequence is emitted only when needed (i.e., when ls thinks a colored name
>has wrapped)?

How would ls know that? `stty cols` (and other ways of obtaining the
column count) may very well emit 0 (can happen on serial or 'dumb'
terminals) or a value that is not right (probably not happening).