[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cp/mv: xattr support
From: |
Kamil Dudka |
Subject: |
Re: [PATCH] cp/mv: xattr support |
Date: |
Fri, 14 Nov 2008 14:36:50 +0100 |
User-agent: |
KMail/1.9.9 |
New version of patch is attached...
Kamil
On Tuesday 11 November 2008 11:25:15 Jim Meyering wrote:
> Please modernize xattr.m4. E.g., use AS_HELP_STRING,
> fix the underquoting errors, a few of which are noted below.
>
> There is more than a little duplication in the set-up for
> the two added tests. Please consider combining them into a single file.
>
> In the tests, use grep -F, not fgrep.
>
> Please use "char const *", not "const char *", and with other types.
>
> Change this both in the commit log 1-line summary and in NEWS:
> s/xattr support/add xattr support/
>
> In the commit log, attribute Andreas.
> Also, give a URL for his unmodified patch, if you can.
0001-cp-mv-add-xattr-support.patch
Description: Text Data