[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
configure syntax issue
From: |
Eric Blake |
Subject: |
configure syntax issue |
Date: |
Tue, 11 Nov 2008 17:54:36 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
While patching autoconf to output fewer blank lines, I noticed this suspicious
construct. One of my potential autoconf changes is making AC_DEFINE no longer
start with a blank line. But that means that coreutils' use of a variable
assignment on the same line as the AC_DEFINE results in the assignment being
temporary to the AC_DEFINE command, rather than persistent to subsequent
commands. OK to apply?
Also, when you removed coreutils/ChangeLog from git, you did not also remove
coreutils/m4/ChangeLog. This is a bit confusing; are you planning on renaming
and/or merging m4/ChangeLog into the main generated top-level ChangeLog?
From: Eric Blake <address@hidden>
Date: Tue, 11 Nov 2008 10:44:59 -0700
Subject: [PATCH] jm-macros.m4: avoid syntax issue with newer autoconf
* jm-macros.m4 (coreutils_MACROS): Make LIB_CAP assignment persistent.
Signed-off-by: Eric Blake <address@hidden>
---
m4/jm-macros.m4 | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
index a691d95..8fa1740 100644
--- a/m4/jm-macros.m4
+++ b/m4/jm-macros.m4
@@ -88,8 +88,9 @@ AC_DEFUN([coreutils_MACROS],
AC_MSG_WARN([libcap support disabled by user]),
[AC_CHECK_LIB([cap], [cap_get_file],
[AC_CHECK_HEADER([sys/capability.h],
- [LIB_CAP=-lcap AC_DEFINE([HAVE_CAP], 1, [libcap usability])],
- [AC_MSG_WARN([header sys/capability.h was not found, support for
libcap will not be built])]
+ [LIB_CAP=-lcap
+ AC_DEFINE([HAVE_CAP], 1, [libcap usability])],
+ [AC_MSG_WARN([header sys/capability.h was not found, support for libcap
will not be built])]
)],
[AC_MSG_WARN([libcap library was not found or not usable, support for
libcap will not be built])])
])
--
1.6.0.2
- configure syntax issue,
Eric Blake <=