bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tests: fix the install/strip-program test


From: Jim Meyering
Subject: [PATCH] tests: fix the install/strip-program test
Date: Sun, 05 Oct 2008 11:06:59 +0200

I noticed a test failure on OpenBSD 3.9.  It was due to a bug
that would probably cause trouble on other systems, too.
Here's the fix:

>From fbc5aa7c47597694d8973a134143a2281748eec6 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 4 Oct 2008 17:12:08 +0200
Subject: [PATCH] tests: fix the install/strip-program test

* tests/install/strip-program: Use $PREFERABLY_POSIX_SHELL,
not POSIX_SHELL.  The latter may be empty, and would fail
on OpenBSD 3.9.
* tests/check.mk (TESTS_ENVIRONMENT): Propagate
PREFERABLY_POSIX_SHELL to tests.
---
 tests/check.mk              |    1 +
 tests/install/strip-program |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tests/check.mk b/tests/check.mk
index cdb199e..0361d0c 100644
--- a/tests/check.mk
+++ b/tests/check.mk
@@ -87,6 +87,7 @@ TESTS_ENVIRONMENT =                           \
   PACKAGE_BUGREPORT='$(PACKAGE_BUGREPORT)'     \
   PACKAGE_VERSION=$(PACKAGE_VERSION)           \
   PERL='$(PERL)'                               \
+  PREFERABLY_POSIX_SHELL='$(PREFERABLY_POSIX_SHELL)' \
   REPLACE_GETCWD=$(REPLACE_GETCWD)             \
   PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
   ; shell_or_perl_
diff --git a/tests/install/strip-program b/tests/install/strip-program
index 98f7feb..8dc838f 100755
--- a/tests/install/strip-program
+++ b/tests/install/strip-program
@@ -26,7 +26,7 @@ fi
 working_umask_or_skip_

 cat <<EOF > b || framework_failure
-#!$POSIX_SHELL
+#!$PREFERABLY_POSIX_SHELL
 sed s/b/B/ \$1 > \$1.t && mv \$1.t \$1
 EOF
 chmod a+x b || framework_failure
--
1.6.0.2.307.gc427




reply via email to

[Prev in Thread] Current Thread [Next in Thread]