[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remov
From: |
Jim Meyering |
Subject: |
Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c |
Date: |
Fri, 26 Sep 2008 10:17:27 +0200 |
Ralf Wildenhues <address@hidden> wrote:
> Hello Jim, a tiny nit again:
>
> Jim Meyering <jim <at> meyering.net> writes:
>> +/* A comparison function to sort on increasing inode number. */
>> +static int
>> +compare_ino (void const *av, void const *bv)
>> +{
>> + struct readdir_data const *const *a = av;
>> + struct readdir_data const *const *b = bv;
>> + return a[0]->ino - b[0]->ino;
>> +}
>
> Susceptible to integer overflow, like the gnulib code.
Yes. Thanks again.
- rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Jim Meyering, 2008/09/25
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Eric Blake, 2008/09/25
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Ralf Wildenhues, 2008/09/26
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c,
Jim Meyering <=
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Andreas Schwab, 2008/09/26
- Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c, Jim Meyering, 2008/09/26