Re: truncate.c fails to compile on make distcheck

[Jim Meyering]

Pádraig Brady <address@hidden> wrote:
> Jim Meyering wrote:
>> Pádraig Brady <address@hidden> wrote:
>>> Jim Meyering wrote:
>>>> By the way, does %zu work reliably everywhere now?
>>>> In the past, we've converted such values to strings via umaxtostr,
>>>> to accommodate older systems.
>>>>
>>>> For ssize and nsize, I have a slight preference for the
>>>> cast-free approach of using %s with imaxtostr.
>>> Yes I suppose %z and PRIdMAX are C99 specific.
>>> How about the attached patch?
>>
>> Thanks!
>> However, I'd prefer to keep the use of PRIdMAX,
>> since gnulib's inttypes.h replacement lets us rely on that,
>> if you don't mind.
>
> I'm a little confused. Did you change your mind and you
> now want to keep the (intmax_t) cast in my original patch?

Sorry.  I'm the one who was confused.
The patch below is perfect.

> I also noticed that the use of size_t is buggy anyway
> in conjunction with off_t, so I've changed that.

Good catch.

>>From ee15430cb9b0de578269262ee149aa9350184354 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Thu, 26 Jun 2008 11:10:13 +0100
> Subject: [PATCH] truncate: Fix integer portability issues
...