Re: [patch 1/4] do not force suid color

[Jan Engelhardt]

On Saturday 2008-06-21 19:37, Jim Meyering wrote:
>To make it red instead of green, you might use this:
>
>    $ LS_COLORS='ex=1;31:sg=' ./ls -log --color


This does not seem to work everywhere:

$ LS_COLORS="" ./ls --color -ld /tmp
drwxrwxrwt 14 root root 4096 Jun 21 20:00 /tmp [the usual 30;42]

$ LS_COLORS="tw=" ./ls --color -ld /tmp
drwxrwxrwt 14 root root 4096 Jun 21 20:00 /tmp [displayed as 34;42]

(ok I just figured that "ow=" kicks in... now that's nasty)

$ LS_COLORS="tw=:ow=" ./ls --color -ld /tmp
drwxrwxrwt 14 root root 4096 Jun 21 20:00 /tmp [displayed as 37;44]

nasty still :)

$ LS_COLORS="tw=:ow=:st=" ./ls --color -ld /tmp
drwxrwxrwt 14 root root 4096 Jun 21 20:00 /tmp [now it's the desired 1;34]


So, your patch works for me.
Thanks!


>And dircolors cannot yet emit such settings:
>
>    $ echo SETGID|dircolors -
>    dircolors: -:1: invalid line;  missing second token
>
>If you (or anyone else) are interested in fixing that (maybe as easy
>as removing the test and ensuring that downstream code can handle NULL
>pointers or empty strings) and adding tests and documentation, that
>would accelerate the process.  Otherwise, I'll do it eventually.

I guess I leave that to you since I would probably do it in
an ad-hoc fashion.