[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FYI: use proper_name and proper_name_utf8
From: |
Jim Meyering |
Subject: |
FYI: use proper_name and proper_name_utf8 |
Date: |
Mon, 26 May 2008 19:58:17 +0200 |
I've pushed a few change sets to make coreutils use gnulib's propername
module (the proper_name and proper_name_utf8).
http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=summary
This change affects every single program. Initially, I used both
functions, but noticed a significant code size increase, so ended up
making proper_name a no-op to save space. Here's the comment I added
in system.h:
+#include "propername.h"
+/* Define away proper_name (leaving proper_name_utf8, which affects far
+ fewer programs), since it's not worth the cost of adding ~17KB to
+ the x86_64 text size of every single program. This avoids a 40%
+ (almost ~2MB) increase in the on-disk space utilization for the set
+ of the 100 binaries. */
+#define proper_name(x) (x)
Here's a detail I would have missed had I not built
on solaris and noticed the link failure there:
Users of the propername function must link with $(LIBICONV).
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- FYI: use proper_name and proper_name_utf8,
Jim Meyering <=