bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: bootstrap dangling symlink tweaks


From: Jim Meyering
Subject: FYI: bootstrap dangling symlink tweaks
Date: Tue, 01 Apr 2008 17:25:54 +0200

I've just pushed a couple tweaks for the dangling symlink
deletion part of bootstrap.  I'll do the same in gnulib shortly.

The first is because I found a few persistent dangling symlinks
in lib/*.[ch] to be annoying.  The second was because when I ran
bootstrap's find command manually (without the stderr redirect),
find-4.4.0 printed this:

  find: warning: you have specified the -depth option after a non-option
  argument -name, but options are not positional (-depth affects tests
  specified before it as well as those specified after it).  Please specify
  options before other arguments.

>From 9b16f4cc8cca9e5712f9e9a082b2d4a1120ba44e Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 1 Apr 2008 17:05:31 +0200
Subject: [PATCH] * bootstrap: Remove dangling symlinks from lib (aka 
$source_base), too.


Signed-off-by: Jim Meyering <address@hidden>
---
 bootstrap |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/bootstrap b/bootstrap
index c1ed9e5..3bfc5d1 100755
--- a/bootstrap
+++ b/bootstrap
@@ -557,7 +557,9 @@ fi
 # since this is only a convenience to help developers avoid the relatively
 # unusual case in which a symlinked-to .m4 file is git-removed from gnulib
 # between successive runs of this script.
-find "$m4_base" -name '*.m4' -depth -type l -xtype l -delete > /dev/null 2>&1
+find "$m4_base" "$source_base" \
+  -name '*.m4' -depth -type l -xtype l -delete > /dev/null 2>&1
+

 # Reconfigure, getting other files.

--
1.5.5.rc2.7.g0b2fe


>From a1a0b32bd79df2c7392fad53dfbc22ab5ef0578d Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 1 Apr 2008 17:12:12 +0200
Subject: [PATCH] bootstrap: make find's -depth option be the first.

* bootstrap [dangling symlink removal]: Move find's -depth
option to precede all others, to avoid a warning.

Signed-off-by: Jim Meyering <address@hidden>
---
 bootstrap |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/bootstrap b/bootstrap
index 3bfc5d1..94d8921 100755
--- a/bootstrap
+++ b/bootstrap
@@ -558,7 +558,7 @@ fi
 # unusual case in which a symlinked-to .m4 file is git-removed from gnulib
 # between successive runs of this script.
 find "$m4_base" "$source_base" \
-  -name '*.m4' -depth -type l -xtype l -delete > /dev/null 2>&1
+  -depth -name '*.m4' -type l -xtype l -delete > /dev/null 2>&1


 # Reconfigure, getting other files.
--
1.5.5.rc2.7.g0b2fe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]