bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Modifiable NMERGE in sort


From: Bo Borgerson
Subject: Re: Modifiable NMERGE in sort
Date: Tue, 1 Apr 2008 10:00:20 -0400

On Tue, Apr 1, 2008 at 4:11 AM, Jim Meyering <address@hidden> wrote:
>  So please see if you can find an option name that does not start with
>  --merge, and, ideally, that doesn't influence interpretation of any
>  other option abbreviations.
>

How about --batch-size.  It doesn't have an initial substring that
coincides with more than a character of an existing longopt, and there
aren't really any other 'batches' in sort aside from these merge
batches (with the exception perhaps of input buffers which are covered
by the the --buffer-size option).  In my personal version I've been
using --nmerge, but I wasn't sure if that was user-friendly enough for
a more general audience.

I've made nmerge an unsigned int and added a check to ensure that it's
not allowed to get bigger than (SIZE_MAX / MIN_MERGE_BUFFER_SIZE).

I also realized that I had introduced tabs into tests/misc/sort-merge
where there previously hadn't been any, so I replaced those with
spaces.

Bo

Attachment: nmerge-2.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]