[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Implement join --check-order and --nocheck-order.
From: |
Dmitry V. Levin |
Subject: |
Re: [PATCH] Implement join --check-order and --nocheck-order. |
Date: |
Sun, 23 Mar 2008 04:23:04 +0300 |
On Tue, Feb 19, 2008 at 03:44:00PM +0100, Jim Meyering wrote:
> James Youngman <address@hidden> wrote:
> > This is a consolidated patch including all the previous changes,
> > implementing order checking in join by default. "make distcheck"
> > works (if I move distcheck-hook from Makefile.am to GNUmakefile).
> >
> > 2008-02-16 James Youngman <address@hidden>
> >
> > * src/join.c: Support --check-order and --nocheck-order.
> > New variables check_input_order, seen_unpairable and
> > issued_disorder_warning[]. For --check-order, verify that the
> ...
>
> Thanks again.
> I've just pushed that.
Looks like this commit v6.10-70-ga1e7156 introduces a regression:
$ printf '%s\n%s\n' '1 b' '2 a' | sort -k2,2 | join -12 -21 - /dev/null
join: File 1 is not in sorted order
$ echo $?
1
$ join --version |grep join
join (GNU coreutils) 6.10.133-677610
--
ldv
pgp1yZUyox1aO.pgp
Description: PGP signature
- Re: [PATCH] Implement join --check-order and --nocheck-order.,
Dmitry V. Levin <=