[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mkdir/split: send --verbose output to stdout + [PATCH]: same
From: |
Ondřej Vašík |
Subject: |
Re: [PATCH] mkdir/split: send --verbose output to stdout + [PATCH]: same for rmdir/install |
Date: |
Mon, 03 Mar 2008 16:04:07 +0100 |
Hello,
I think there are still some things to be consolidated.
The same with verbose output should be done in the case
of install(when making dir) and in the case of rmdir.
In the case of shred should be mentioned in info that
verbose output is to standard error.
Those things done in attached patch, should break
no tests (as rmdir has no verbose test and install
verbose test redirects stdout and stderr to the one
file)
Greetings,
Ondrej Vasik
Jim Meyering wrote:
> Steven Schubiger <address@hidden> wrote:
> > +2008-02-01 Steven Schubiger <address@hidden>
> > +
> > + * src/mkdir.c: Send --verbose output to stdout.
> > + * src/split.c: Likewise.
> > + Update texinfo documentation for split.
> > + Adjust tests for mkdir/split.
> > + * tests/mkdir/p-v: Capture verbose output which previously was
> > + being emitted to stderr from stdout.
> > + * tests/misc/split-a: Likewise.
>
> Thanks for the patch.
> I've made some minor changes and handled the usual administrivia.
>
> mkdir, split: write --verbose output to stdout, not stderr.
>
> * src/mkdir.c (verbose_output): New function.
> (announce_mkdir): Use it.
> * src/split.c (usage): Update.
> * src/split.c (cwrite): Write to stdout, not stderr.
> * doc/coreutils.texi (split invocation): Remove the mention
> of --verbose output being printed to stderr.
> * tests/mkdir/p-v: Redirect stdout, not stderr.
> * tests/misc/split-a: Likewise.
> * NEWS: Mention this change.
> * TODO: Remove this item.
>
> Signed-off-by: Jim Meyering <address@hidden>
coreutils-rmdir-install-verbosity.patch
Description: Text Data
signature.asc
Description: Toto je digitálně podepsaná část zprávy
- Re: [PATCH] mkdir/split: send --verbose output to stdout + [PATCH]: same for rmdir/install,
Ondřej Vašík <=