bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: argve0, psfool


From: Mike Frysinger
Subject: Re: argve0, psfool
Date: Mon, 24 Dec 2007 14:10:32 -0500
User-agent: KMail/1.9.7

On Monday 24 December 2007, Daniel C. Bastos wrote:
> #define min(a,b) (a) <= (b) ? (a) : (b)

there's already a MIN() macro

> #define SIZE 256

non-descript magic #

>   int i; char real[128]; char fake[128]; char vargv[8192]; int n;
>   strncpy(fake, argv[1], n); fake[n] = '\0';
>   strncpy(real, argv[2], n); real[n] = '\0';

these should be on separate lines.  i'm guessing your 8192 should actually be   
                         
BUFSIZ.  then again, the whole arg shifting looks like voodoo and could 
(should?) be simpler.  *shrug*
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]