Re: a coreutils release is imminent

[Jim Meyering]

Paul Eggert <address@hidden> wrote:

> Eric Blake <address@hidden> writes:
>
>> tests/mv:
>> ls: cannot access x/b: No such file or directory
>> ./hard-3: line 87: test: 10133099161893214: unary operator expected
>> FAIL: hard-3
>
> That looks to me like a failure in the test suite, in that it reports
> a bogus error when the real error is elsewhere.  Here is a patch for
> the test-suite problem.
>
> 2007-03-22  Paul Eggert  <address@hidden>
>
>       * tests/mv/hard-3: Check for 'ls' failure, too.
>       Generate more-useful debugging output when 'ls' fails.
>
> diff --git a/tests/mv/hard-3 b/tests/mv/hard-3
> index 0ab9521..3bc60c0 100755
> --- a/tests/mv/hard-3
> +++ b/tests/mv/hard-3
> @@ -2,7 +2,7 @@
>  # Ensure that using `cp --preserve=link' to copy hard-linked arguments
>  # onto existing destinations works, even when one of the link operations 
> fails.
>
> -# Copyright (C) 2003, 2006 Free Software Foundation, Inc.
> +# Copyright (C) 2003, 2006, 2007 Free Software Foundation, Inc.
>
>  # This program is free software; you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -78,12 +78,12 @@ test -f x/b || fail=1
>  test -f c || fail=1
>
>  # The i-node numbers of a and c must be the same.
> -ia=`ls -i a|sed 's/ a$//'`
> -ic=`ls -i c|sed 's/ c$//'`
> -test $ia = $ic || fail=1
> +ia=`ls -i a` || fail=1; set x $ia; ia=$3
> +ic=`ls -i a` || fail=1; set x $ic; ic=$3

Thanks.  I'm applying that, but with one correction:
the ic=... line should apply ls to "c", not "a".