[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

base64.c infelicity with out versus stdout

From: Paul Eggert
Subject: base64.c infelicity with out versus stdout
Date: Fri, 14 Jul 2006 10:56:11 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

I installed this to fix some confusing code in base64.c:

2006-07-14  Paul Eggert  <address@hidden>

        * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
        This doesn't fix any bugs, since OUT always equals stdout, but it
        makes the code easier to understand.

--- src/base64.c        5 Mar 2006 11:20:53 -0000       1.5
+++ src/base64.c        14 Jul 2006 17:54:54 -0000      1.6
@@ -214,7 +214,7 @@ do_decode (FILE *in, FILE *out, bool ign
       n = BLOCKSIZE;
       ok = base64_decode (inbuf, sum, outbuf, &n);
-      if (fwrite (outbuf, 1, n, stdout) < n)
+      if (fwrite (outbuf, 1, n, out) < n)
        error (EXIT_FAILURE, errno, _("write error"));
       if (!ok)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]