[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] 5.95: who(1) overflow
From: |
Jim Meyering |
Subject: |
Re: [patch] 5.95: who(1) overflow |
Date: |
Wed, 17 May 2006 15:20:41 +0200 |
Tim Waugh <address@hidden> wrote:
> Here is a patch for RH bugzilla bug #158405, in which who(1) overflows
> a buffer.
>
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=158405
>
> 'LC_ALL=de_DE.UTF-8 /usr/bin/who -Hliw' is what triggers it.
>
> --- coreutils-5.2.1/src/who.c.overflow 2005-05-25 09:59:06.000000000
> +0100
> +++ coreutils-5.2.1/src/who.c 2005-05-25 10:00:31.000000000 +0100
> @@ -75,7 +75,7 @@
> # define NEW_TIME 0
> #endif
>
> -#define IDLESTR_LEN 6
> +#define IDLESTR_LEN 10
Thanks, Tim.
That's definitely a bug.
However, it needs more space than that, for example to handle the Kinyarwanda
translation, which has strlen == 11. I'll prepare a more ambitious patch.