Re: Re-2: mv do not preserves default acls

[Andreas Gruenbacher]

Jim and others,

[CC cut]

On Thursday 20 October 2005 11:42, Jim Meyering wrote:
> Hi Andreas!
>
> Andreas Gruenbacher <address@hidden> wrote:
> ...
>
> > There are patches for coreutils-5.90 now -- I just updated the diffs.
> > I'll happily send them if anyone is interested.
>
> Great!  I'm interested.

please find the patches at http://www.suse.de/~agruen/coreutils/. They are 
against 5.91 right now.

> > Jim, you wrote:
> >> We haven't integrated support for ACLs, yet.
> >> There are patches being used by several distributions.
> >> If there's interest, I'll begin distributing one of those
> >> patch sets -- and keeping it in sync -- so people don't have
> >> to struggle through merges all the time.
> >
> > I would much more appreciate if you could finally integrate the patches,
> > or if we could work out something that you consider mergeable by your
> > standards.
>
> I've never seen patches that add tests.

I had a few tests a very long time ago, then dropped them because the test 
changes didn't apply again and again. I'll create new tests that cover the 
changes.

> Adding tests is an important prerequisite for such a significant
> change.  For example, I recall at least one ACL-related bug being
> reported, then fixed in the last couple of years.  It'd be nice to
> have a test case to exercise the changed behavior in each such case.

Agreed.

> Of course, such tests would have to depend on finding a writable
> directory in an ACL- or XATTR-enabled partition as well as a few
> related tools.  You could require that each such directory be
> specified via an environment variable.  If it's not set, or not
> the right type, or required tools are missing, then just skip the test.
> You can even add root-only tests, if necessary.

It'll probably work out to run the acl (and xattr) tests when those features 
are compiled in. Most systems nowadays should enable those features by 
default, anyway.

Cheers,
Andreas.