bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Re3: coreutils v5.2.1 - stat.c


From: Paul Eggert
Subject: Re: Re3: coreutils v5.2.1 - stat.c
Date: Thu, 29 Sep 2005 09:52:57 -0700
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

ThMO <address@hidden> writes:

> the header file xtime.h defines:
>   # if HAVE_LONG_LONG
>   typedef long long int xtime_t;
>   #  define XTIME_PRECISION 1000000000LL
>   # else
>   ...
>   #endif
> Again cpp groks about the `LL' modifier.

Thanks for catching that portability problem to GCC 2.7.2.1.  Please
try the following patch, which I have installed into coreutils and
gnulib CVS.  I have manually verified that no other code cares whether
XTIME_PRECISION is of type int or long long int.

2005-09-29  Paul Eggert  <address@hidden>

        * xtime.h (XTIME_PRECISION): Now of type int, not long long int,
        so that the code works even with ancient cpp.  Portability problem
        with GCC 2.7.2.1 reported by Thomas M.Ott.

--- xtime.h     14 May 2005 08:03:44 -0000      1.3
+++ xtime.h     29 Sep 2005 16:51:40 -0000      1.4
@@ -27,14 +27,14 @@
    seconds.  */
 # if HAVE_LONG_LONG
 typedef long long int xtime_t;
-#  define XTIME_PRECISION 1000000000LL
+#  define XTIME_PRECISION 1000000000
 # else
 #  include <limits.h>
 typedef long int xtime_t;
 #  if LONG_MAX >> 31 >> 31 == 0
-#   define XTIME_PRECISION 1L
+#   define XTIME_PRECISION 1
 #  else
-#   define XTIME_PRECISION 1000000000L
+#   define XTIME_PRECISION 1000000000
 #  endif
 # endif
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]