bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils 5.2.1 make check fails


From: Jim Meyering
Subject: Re: coreutils 5.2.1 make check fails
Date: Mon, 21 Jun 2004 20:44:26 +0200

michael <address@hidden> wrote:
> If there is a fix for this, assuming its a bug, I would appreciate
> greatly knowing outside of the email list as I dont frequent it very
> often.  If its something on my side and you have spotted it I would
> also like to know.

Thanks for persevering.
This is not due to a bug in the tools themselves.
Rather it is due to a weakness in the test harness
that's exposed only when running `make check' as root
and when some other version of a tool like chmod or rm
is first in your PATH.

This patch should fix it:

2004-06-21  Jim Meyering  <address@hidden>

        * tests/priv-check: When running as root, be sure to propagate
        PATH through to the process we exec as non-root.
        Reported by address@hidden

Index: tests/priv-check
===================================================================
RCS file: /fetish/cu/tests/priv-check,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -p -u -r1.7 -r1.8
--- tests/priv-check    27 Jul 2003 20:04:48 -0000      1.7
+++ tests/priv-check    21 Jun 2004 17:06:58 -0000      1.8
@@ -60,7 +60,7 @@ case $PRIV_CHECK_ARG:$my_uid in
        echo "$0: skipping this test" 1>&2
        (exit 77); exit
       }
-    exec setuidgid $NON_ROOT_USERNAME $0
+    exec setuidgid $NON_ROOT_USERNAME env PATH=$PATH $0
     ;;
   require-non-root:*) ;;
 esac




reply via email to

[Prev in Thread] Current Thread [Next in Thread]