[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dd PATCH: add conv=direct
From: |
Andy Isaacson |
Subject: |
Re: dd PATCH: add conv=direct |
Date: |
Wed, 7 Apr 2004 14:24:32 -0500 |
User-agent: |
Mutt/1.4.1i |
On Wed, Apr 07, 2004 at 11:18:41AM -0700, Andrew Morton wrote:
> Andy Isaacson <address@hidden> wrote:
> > > While you're there, please add an fsync-before-closing option.
> >
> > Easy enough. How does this look? Note that C_TWOBUFS ensures the
> > output buffer is getpagesize()-aligned.
>
> Looks nice and simple. You'll need an ext2 filesystem to test it under 2.4.
I tested against a block device. Easier to just "swapoff /dev/hda2"
than to find space to make a new filesystem.
> Be aware that it's rather a challenge to actually get the O_DIRECT #define
> in scope under some glibc versions. I think you need to define _GNU_SOURCE
> or something like that.
Yeah, I had to -D_GNU_SOURCE to build standalone, but coreutils'
makefile seems to do OK.
Would there be any reason to allow O_DIRECT on the read side?
-andy
- dd PATCH: add conv=direct, Andy Isaacson, 2004/04/07
- Re: dd PATCH: add conv=direct, Andrew Morton, 2004/04/07
- Re: dd PATCH: add conv=direct, Bruce Allen, 2004/04/07
- Re: dd PATCH: add conv=direct, Andy Isaacson, 2004/04/07
- Re: dd PATCH: add conv=direct, Andrew Morton, 2004/04/07
- Re: dd PATCH: add conv=direct,
Andy Isaacson <=
- Re: dd PATCH: add conv=direct, Andrew Morton, 2004/04/07
- Re: dd PATCH: add conv=direct, Andy Isaacson, 2004/04/07
- Re: dd PATCH: add conv=direct, Andrew Morton, 2004/04/07
- Re: dd PATCH: add conv=direct, Andy Isaacson, 2004/04/07
- Re: dd PATCH: add conv=direct, Valdis . Kletnieks, 2004/04/08
- Re: dd PATCH: add conv=direct, Bruce Allen, 2004/04/08
- Re: dd PATCH: add conv=direct, Paul Eggert, 2004/04/08
- Re: dd PATCH: add conv=direct, Jim Meyering, 2004/04/08
- Re: dd PATCH: add conv=direct, Paul Eggert, 2004/04/08
- Re: dd PATCH: add conv=direct, Paul Jarc, 2004/04/08