[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coreutils 5.0.1: spurious error from uniq
From: |
Paul Eggert |
Subject: |
Re: Coreutils 5.0.1: spurious error from uniq |
Date: |
18 Jul 2003 10:52:48 -0700 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 |
Andreas Schwab <address@hidden> writes:
> 2003-07-18 Andreas Schwab <address@hidden>
>
> * memcoll.c (memcoll) [!HAVE_STRCOLL]: Clear errno.
>
> --- coreutils-5.0.1/lib/memcoll.c.~1~ 2003-06-06 22:11:58.000000000 +0200
> +++ coreutils-5.0.1/lib/memcoll.c 2003-07-18 11:58:37.000000000 +0200
> @@ -83,6 +83,7 @@ memcoll (char *s1, size_t s1len, char *s
> diff = memcmp (s1, s2, s1len < s2len ? s1len : s2len);
> if (! diff)
> diff = s1len < s2len ? -1 : s1len != s2len;
> + errno = 0;
>
> #endif
>
Thanks for that fix. I checked it into gnulib. (Wow, your memcmp
implementation sets errno? It's allowed to, but out of curiosity why
does it do that?)
The other part of your coreutils fix is probably better served by
migrating gnulib's m4 stuff into coreutils; I'll address that in a
different message.