Re: bug in french localization

[Martin Quinson]

[please keep CCing me and the debian bug]

Hi Jim !

Thanks for that patch, that's definitivelly a step in the right direction.
I'm so happy that something happened about this bug ! I should have contact
you before.

The only problem is that this fix may be somehow partial. Could you do the
same handling for all fields, and not only the "filesystem" one, please?

It shouldn't be really hard, but the code may become pretty hairly. I'm not
sure what the best solution is...


Thanks for your intervention, Mt.

On Wed, Feb 19, 2003 at 05:07:08PM +0100, Jim Meyering wrote:
> ...
> > (http://bugs.debian.org/cgi-bin/bugreport.cgi?archive=no&bug=131113)
> > and comment?
> 
> Hi Martin!
> 
> Thanks for bringing that to my attention!
> I've just fixed it like this:
> 
> 2003-02-19  Jim Meyering  <address@hidden>
> 
>       * src/df.c (print_header): Rather than using a hard-coded literal
>       string of spaces matching the length of the English `...Type' header,
>       output the right number of spaces to match the selected translation.
>       Reported by Yann Dirson and Jean Charles Delepine as Debian bug 131113.
> 
> Index: df.c
> ===================================================================
> RCS file: /fetish/cu/src/df.c,v
> retrieving revision 1.139
> retrieving revision 1.140
> diff -u -p -u -r1.139 -r1.140
> --- df.c      5 Feb 2003 07:01:27 -0000       1.139
> +++ df.c      19 Feb 2003 16:05:07 -0000      1.140
> @@ -148,13 +148,16 @@ static void
>  print_header (void)
>  {
>    char buf[MAX (LONGEST_HUMAN_READABLE + 1, INT_BUFSIZE_BOUND (uintmax_t))];
> +  char const *type_header = _("   Type");
>  
>    printf (_("Filesystem "));
>  
> +  /* Print the `Type' header if required (--print-type, -T),
> +     or an equivalent number of spaces.  */
>    if (print_type)
> -    printf (_("   Type"));
> +    fputs (type_header, stdout);
>    else
> -    printf ("       ");
> +    printf ("%-*s", strlen (type_header), "");
>  
>    if (inode_format)
>      printf (_("    Inodes   IUsed   IFree IUse%%"));
>