'define' can turn on arbitray class

[Wipf, Stefan]

We are using cfengine-1.6.3 on solaris 2.6 and 2.8

When trying to figure out why cfengine was all of sudden exhibiting
some rather strange behaviour, we noticed that sometimes weird and
undeclared new classes like '_', '__k' or 'ini' appeared out of nowhere. 

And worse, some machines suddenly appeared in classes that we defined
but which they clearly should not have been members of. 
This of course, was the root cause of the strange behavior we were
seeing.


Further investigation let us to conclude that 'define=someclass'
expressions in our copy sections did not just turn on the class
'someclass'  but also all of the unexpected classes we were seeing.

 
>From cfengine -d2: 
  ..
  AddMultipleClasses(someclass)
  ..
  AddClassToHeap(someclass)
  AddClassToHeap(___ini)
  .. 


Our workaround:

As cfengine exhibits problems parsing the class-list following a 
'define=' if it consists of a single element, we replaced all single
element class-lists with class-lists of the form 'someclass,' or 
'someclass,any'.
So far, this appears to work.


-- 
Stefan Wipf
address@hidden