Re: Bison 3.2.90 released [beta]

[Akim Demaille]

> Le 15 janv. 2019 à 19:44, Derek Clegg <address@hidden> a écrit :
> 
> Thanks for this fix. I had some problems applying the patch, so I’ll wait 
> until the next release candidate to test it.

It should be soon.  I have a few things I would like to improve with --update.

> It looks okay, however, based on a brief inspection. One thing:
> 
>> if test "$enable_gcc_warnings" = yes; then
>>  warn_common='-Wall -Wextra -Wno-sign-compare -Wcast-align
>>    -fparse-all-comments -Wdocumentation
>> -    -Wformat -Wnull-dereference -Wpointer-arith -Wshadow -Wwrite-strings'
>> +    -Wformat -Wnull-dereference -Wpointer-arith -Wshadow
>> +    -Wundefined-func-template -Wwrite-strings'
>>  warn_c='-Wbad-function-cast -Wstrict-prototypes'
>>  warn_cxx='-Wextra-semi -Wnoexcept'
>>  # Warnings for the test suite only.
> 
> I would expect “-Wundefined-func-template” to appear in “warn_cxx”, not 
> “warn_common”. But I may not fully understand what’s going on here.

Of course you are right.  configure.ac correctly sees that it does not make 
sense for the C compiler, but it should go in warn_cxx.  Thanks!