bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/22263] -fpie -pie generates dynamic relocations in text section


From: cvs-commit at gcc dot gnu.org
Subject: [Bug ld/22263] -fpie -pie generates dynamic relocations in text section
Date: Tue, 06 Feb 2018 17:18:33 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=22263

--- Comment #15 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Eric Botcazou <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c20c30f615756ddfccc4bb75c65ccfc1a399466e

commit c20c30f615756ddfccc4bb75c65ccfc1a399466e
Author: Eric Botcazou <address@hidden>
Date:   Tue Feb 6 18:15:56 2018 +0100

    Fix PR ld/22263 on SPARC.

    This is -fpie -pie generating dynamic relocations in the text section,
    simply because no TLS transitions are applied in PIE mode.  The meat
    of the patch is to turn calls to bfd_link_pic (info) in TLS-related code
    into !bfd_link_executable (info) and there are quite a lot of them...

    bfd/
        * elfxx-sparc.c (sparc_elf_tls_transition): Turn call to bfd_link_pic
        into call to !bfd_link_executable and tidy up.
        (_bfd_sparc_elf_check_relocs): Fix formatting and tidy up.
        <R_SPARC_TLS_LE_HIX22>: Turn call to bfd_link_pic into call to
        !bfd_link_executable.
        <R_SPARC_TLS_IE_HI22>: Likewise.
        <GOT relocations>: Remove useless code, tidy and merge blocks.
        <R_SPARC_TLS_GD_CALL>: Turn call to bfd_link_pic into call to
        !bfd_link_executable.
        <R_SPARC_WPLT30>: Tidy up.
        (_bfd_sparc_elf_gc_mark_hook): Turn call to bfd_link_pic into call
        to !bfd_link_executable.
        (allocate_dynrelocs): Likewise.
        (_bfd_sparc_elf_relocate_section): Fix formatting and tidy up.
        <R_SPARC_TLS_GD_HI22>: Merge into...
        <R_SPARC_TLS_GD_LO10>: ...this.  Adjust 4th argument in call to
        sparc_elf_tls_transition and remove redundant code.
        <R_SPARC_TLS_LDM_HI22>: Turn call to bfd_link_pic into call to
        !bfd_link_executable.
        <R_SPARC_TLS_LDO_HIX22>: Likewise.
        <R_SPARC_TLS_LE_HIX22>: Likewise.  Tidy up.
        <R_SPARC_TLS_LDM_CALL>: Likewise.
        <R_SPARC_TLS_GD_CALL>: Likewise.  Tidy up.
        <R_SPARC_TLS_GD_ADD>: Likewise.
        <R_SPARC_TLS_LDM_ADD>: Likewise.
        <R_SPARC_TLS_LDO_ADD>: Likewise.
        <R_SPARC_TLS_IE_LD>: Likewise.
    ld/
        * testsuite/ld-elf/tls.exp (AFLAGS_PIC): Define on SPARC.
        (pr22263-1): Pass AFLAGS_PIC to the assembler.
        * testsuite/ld-sparc/tlspie32.s: Add test for other 3 transitions.
        * testsuite/ld-sparc/tlspie32.dd: Adjust to above.
        * testsuite/ld-sparc/tlspie64.s: Add test for other 3 transitions.
        * testsuite/ld-sparc/tlspie64.dd: Adjust to above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]