[Bug binutils/19005] objcopy buffer-over-read

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19005

--- Comment #18 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Andrew Stubbs from comment #17)
> I can check this tomorrow, but I don't think the output size is actually
> broken, as long as everything respects the input size when reading from
> input sections. The "change something, change it back, change it again"
> business seems a bit clumsy.
> 
> That said, it looks like it will fix the bug.
> 
> Incidentally, you clearly don't like something about my patch, but you've
> not said what?

copy_object adds gap fills behind the back of bfd.
I'd like to separate bfd_convert_section_contents from
copy_section so that there aren't surprises in bfd.
When copy_object does

 /* This has to happen after the symbol table has been set.  */
  bfd_map_over_sections (ibfd, copy_section, obfd);

it should only copy bfd_section_size (obfd, osections[i]) - gaps[i],
not lying to bfd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.