[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too
From: |
James E Wilson |
Subject: |
Re: [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too) |
Date: |
Mon, 28 Mar 2005 13:36:02 -0800 |
On Mon, 2005-03-28 at 13:03, hjl at lucon dot org wrote:
> This patch adds "-mtune=[itanium1|itanium2]". I will update
> NEWS and doc if it is OK.
I think the extra_goodness change is a little confusing. You are
reusing the parameter "slot" for the return value, even though the
return value has nothing to do with slot numbers. I had to read the
code twice before I figured out why you were changing the slot numbers.
I would prefer a new local variable named "goodness" or "retval" or
whatever. And then we can initialize it to a sensible value like 0. Or
perhaps just "return 2" instead of "slot = 2" like the original code
had. There is also the issue that maybe there should be a "default:
abort ();" to make sure the code gets appropriately modified when future
processors are added.
Otherwise, it all looks OK to me.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), (continued)
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), davidm at hpl dot hp dot com, 2005/03/24
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), hjl at lucon dot org, 2005/03/24
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), wilson at specifixinc dot com, 2005/03/24
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), hjl at lucon dot org, 2005/03/24
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), wilson at specifixinc dot com, 2005/03/24
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), hjl at lucon dot org, 2005/03/25
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), wilson at specifixinc dot com, 2005/03/25
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), hjl at lucon dot org, 2005/03/28
- Re: [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too),
James E Wilson <=
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), hjl at lucon dot org, 2005/03/28
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), wilson at specifixinc dot com, 2005/03/28
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), wilson at specifixinc dot com, 2005/03/28
- [Bug gas/803] gas should avoid F-unit NOPs (and B-unit probably, too), wilson at specifixinc dot com, 2005/03/28