|
From: | Vladimir Merzliakov |
Subject: | Re: Binutils build broken at FreeBSD 5.3 after -Werror enabling |
Date: | Thu, 24 Mar 2005 21:04:32 +0300 |
Well that should be long enough. I think that the patch is OK, but there are two problems:Patch rejected by libiberty maintainer ( http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02291.html ):1. The patch should be submitted to the gcc project, since they control the getopt.h header file.2. You need to include a ChangeLog entry with your patch.
ian> Sorry, this patch is not OK. It will just lead us down the path of ian> increasing the #ifdef over and over again. The question here is why ian> HAVE_DECL_GETOPT is not defined. ian> ian> Looking at gcc, I would say that the binutils configure.in file should ian> do the equivalent of gcc_AC_CHECK_DECLS(getopt) to get ian> HAVE_DECL_GETOPT defined appropriately. I am not gury in configure magic and then I can't provide acceptable patch. Sorry. Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |