Re: Adding support of the z/OS platform

[Chet Ramey]

On 5/16/23 12:10 PM, Igor Todorovski wrote:
> Hi there,
>
> I’m looking for advice on the best way to submit a patch to enable support of 
> z/OS.
>
> We have a few patches here which I will be cleaning up for the next few days: 
> https://github.com/ZOSOpenTools/bashport/tree/main/patches

You can just send me a note when these are cleaned up, as long as I can
get to the link then.

I looked at them, and I'm wondering why you patched configure instead of
configure.ac and aclocal.m4. Do you not have autoconf? If someone happens
to run autoconf in that directory, it will overwrite your changes.

Some of these patches (e.g., the one to sig.c) seem to indicate bugs in
z/OS (sigaction doesn't modify its second argument).


> Also, on z/OS we have a prefix message id before the error text as in this 
> case: 
> https://github.com/ZOSOpenTools/bashport/blob/main/patches/PR3/builtins.right.patch
>
> Is there a preferred approach for how to handle this? Should I create a 
> builtins.right.zos?

That's a one-off patch to deal with a specific environment. I'd either just
add a warning to the test script or keep it in your local branch. There are
already some warnings to deal with different signal ordering and some
other messages that differ between systems (ok, between Solaris and
everything else).

Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/