Re: coreutils' parallel make distcheck now fails

[Ralf Wildenhues]

* Jim Meyering wrote on Fri, Apr 10, 2009 at 02:51:08PM CEST:
> > 2009-04-10  Ralf Wildenhues  <address@hidden>
> >
> >     Fix parallel distcheck failure.
> >     * maint.mk (ALL_RECURSIVE_TARGETS): Add patch-check,
> >     check-AUTHORS, maintainer-distcheck, vc-dist, taint-distcheck,
> >     my-distcheck, alpha, beta, major.

> Thanks for that patch.
> I should have mentioned that I'd tried a few
> ALL_RECURSIVE_TARGETS additions before resorting
> to the kludge.  Unfortunately even with your more complete
> list (which I expect to commit) I still see the same failure:

Thanks.  I can reproduce a similar issue even with a single processor
and -j3.  I missed out a couple of files in the first version of the
patch.  Here's a better one.

With it, I still got an error, but once I ran "make all" before
  make -j3 distcheck

then the latter seems to work.

Cheers,
Ralf

2009-04-10  Ralf Wildenhues  <address@hidden>

        Fix parallel distcheck failure.
        * Makefile.am (ALL_RECURSIVE_TARGETS): Initialize here, too,
        to please automake.  Add install-root, check-root,
        distcheck-hook.
        * cfg.mk (ALL_RECURSIVE_TARGETS): Add sc_tight_scope.
        * maint.mk (ALL_RECURSIVE_TARGETS): Add patch-check,
        check-AUTHORS, maintainer-distcheck, vc-dist, taint-distcheck,
        my-distcheck, alpha, beta, major.

diff --git a/Makefile.am b/Makefile.am
index 088cf4f..13891ee 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,6 +15,8 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+ALL_RECURSIVE_TARGETS =
+
 SUBDIRS = lib src doc man po tests gnulib-tests
 
 changelog_etc =                                \
@@ -67,12 +69,14 @@ EXTRA_DIST =                                \
   gl/modules/getloadavg.diff           \
   maint.mk
 
+ALL_RECURSIVE_TARGETS += install-root
 install-root:
        cd src && $(MAKE) $@
 
 ACLOCAL_AMFLAGS = -I m4
 
 # Some tests always need root privileges, others need them only sometimes.
+ALL_RECURSIVE_TARGETS += check-root
 check-root:
        cd tests && $(MAKE) $@ SUBDIRS=
 
@@ -108,6 +112,7 @@ gen-ChangeLog:
          mv $(distdir)/cl-t $(distdir)/ChangeLog;                      \
        fi
 
+ALL_RECURSIVE_TARGETS += distcheck-hook
 distcheck-hook: check-ls-dircolors
        $(MAKE) my-distcheck
 
diff --git a/cfg.mk b/cfg.mk
index f5dab6a..7f4cdd2 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -167,6 +167,7 @@ sc_sun_os_names:
          { echo '$(ME): found misuse of Sun OS version numbers' 1>&2;  \
            exit 1; } || :
 
+ALL_RECURSIVE_TARGETS += sc_tight_scope
 sc_tight_scope:
        @$(MAKE) -C src $@
 
diff --git a/maint.mk b/maint.mk
index 8b2ea6c..1e6b13f 100644
--- a/maint.mk
+++ b/maint.mk
@@ -484,6 +484,7 @@ update-NEWS-hash: NEWS
          $(srcdir)/cfg.mk
 
 epoch_date = 1970-01-01 00:00:00.000000000 +0000
+ALL_RECURSIVE_TARGETS += patch-check
 # Ensure that the c99-to-c89 patch applies cleanly.
 patch-check:
        rm -rf src-c89 address@hidden address@hidden
@@ -509,6 +510,7 @@ patch-check:
        test "$$msg" = ok && rm -rf src-c89 address@hidden address@hidden || 
echo "$$msg" 1>&2; \
        test "$$msg" = ok
 
+ALL_RECURSIVE_TARGETS += check-AUTHORS
 check-AUTHORS:
        $(MAKE) -C src $@
 
@@ -643,6 +645,7 @@ vc-diff-check:
 
 cvs-check: vc-diff-check
 
+ALL_RECURSIVE_TARGETS += maintainer-distcheck
 maintainer-distcheck:
        $(MAKE) distcheck
        $(MAKE) taint-distcheck
@@ -651,6 +654,7 @@ maintainer-distcheck:
 
 # Don't make a distribution if checks fail.
 # Also, make sure the NEWS file is up-to-date.
+ALL_RECURSIVE_TARGETS += vc-dist
 vc-dist: $(local-check) cvs-check maintainer-distcheck
        XZ_OPT=-9ev $(MAKE) dist
 
@@ -686,6 +690,7 @@ fake_home = $(tp)/home
 # and don't affect anything in $HOME.  Create witness files in $HOME,
 # record their attributes, and build/test.  Then ensure that the
 # witnesses were not affected.
+ALL_RECURSIVE_TARGETS += taint-distcheck
 taint-distcheck: $(DIST_ARCHIVES)
        test -d $(t_taint) && chmod -R 700 $(t_taint) || :
        -rm -rf $(t_taint) $(fake_home)
@@ -774,6 +779,7 @@ endef
 # the build srcdir, these always-failing programs will run.
 # Otherwise, it is too easy to test the wrong programs.
 # Note that "false" itself is a symlink to true, so it too will malfunction.
+ALL_RECURSIVE_TARGETS += my-distcheck
 my-distcheck: $(DIST_ARCHIVES) $(local-check)
        $(MAKE) syntax-check
        $(MAKE) check
@@ -855,6 +861,7 @@ define emit-commit-log
 endef
 
 .PHONY: alpha beta major
+ALL_RECURSIVE_TARGETS += alpha beta major
 alpha beta major: $(local-check) writable-files
        test $@ = major                                         \
          && { echo $(VERSION) | grep -E '^[0-9]+(\.[0-9]+)+$$' \