bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: automake 1.5 generates a 'make dist' that does a chmod a+w on source


From: Akim Demaille
Subject: Re: automake 1.5 generates a 'make dist' that does a chmod a+w on sources
Date: 05 Nov 2001 18:02:36 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Artificial Intelligence)

| When building tar 1.13.24 I discovered that 'make dist' did a chmod
| a+w on my original sources.  This is because 'make dist' uses hard
| links to build a temporary directory containing the distribution, and
| then does a 'chmod -R a+w' on the temporary directory just before
| removing it.  That chmod has an undesirable side effect on the
| original source files.

I must say I don't understand too well the kind of changes that affect
your actual sources...

| Here is a patch to cause 'make dist' to chmod u+w only, and only on
| directories, as that's all that is really needed to allow 'rm -fr' to
| succeed.
| 
| 2001-09-14  Paul Eggert  <address@hidden>
| 
|       * lib/am/distdir.am (REMOVE_DISTDIR):
|       New macro.  Do not change permission of non-directories.
|       Change only user permission, as there's no point to changing group
|       or other permission.
|       (distdir, dist, dist-bzip2, dist-tarZ, dist-shar, dist-zip, dist-all,
|        distcheck): Use it.

But the patch is fine.  Could you install it please?  Just
s/REMOVE_DISTDIR/am__remove_distdir/ to cope with the new name space
conventions.

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]