|
From: | Eric Blake |
Subject: | Re: tests: avoid empty AT_DATA contents, for zsh. |
Date: | Mon, 13 Sep 2010 11:09:04 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.3 |
[adding bug-autoconf] On 09/13/2010 08:18 AM, Eric Blake wrote:
On 09/13/2010 08:16 AM, Eric Blake wrote:On 09/12/2010 09:30 AM, Ralf Wildenhues wrote:This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. cat>file<<EOF EOF produces an empty file with sh, but a file containing a newline with zsh, even after 'emulate sh'. autoconf.texi patch coming up too, I guess.Ouch - that's a nasty bug. Have you reported it to the zsh list yet?Hmm, rather than fixing all _our_ uses of AT_DATA, but still having the problem for other clients, why not instead fix AT_DATA to special-case the empty argument to do the right thing for everyone? Don't apply this patch, and I'll help come up with an alternative.
Oops - I thought your patch was for autoconf when I asked you not to apply the patch. On re-reading this, I see that it is a libtool patch instead. Go ahead and apply the libtool patch, since you can't guarantee (or don't want to limit yourself to) a new enough autoconf. Meanwhile, in parallel, I will be patching autoconf to make AT_DATA explicitly allow empty files in 2.68.
-- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |