Re: [Bug-apl] SVN 839 doesn't compile

[Christian Robert]

A clean reinstall from the SVN server + "-Wno-array-bounds" did the trick for 
the pie3.

The "-I sql" is no longer missing.

thanks,
Xtian.

On 2017-01-11 15:17, Juergen Sauermann wrote:
> Hi Xtian,
>
> did you *svn up* and run *./configure* recently? Your *-I *options look a bit 
> wrong. Mine are:
>
> *g++ -DHAVE_CONFIG_H -I. -I..    -Werror -Wall -I/usr/include -I sql  
> -I/usr/include/postgresql -I sql  -rdynamic -g -O2 -MT apl-Quad_SQL.o -MD -MP 
> -MF .deps/apl-Quad_SQL.Tpo -c -o apl-Quad_SQL.o `test -f 'Quad_SQL.cc' || echo 
> './'`Quad_SQL.cc**
> *
> Also, *make clean* sometimes helps.
>
> /// Jürgen
>
>
> On 01/11/2017 08:46 PM, Christian Robert wrote:
> > I hacked src/Makefile to add -Wno-array-bounds to the compile options on the 
> > Raspberry PI3
> >
> > g++ -DHAVE_CONFIG_H -I. -I..    -Wall -Wno-array-bounds -Werror     -rdynamic 
> > -g -O2 -MT apl-Quad_FIO.o -MD -MP -MF .deps/apl-Quad_FIO.Tpo -c -o 
> > apl-Quad_FIO.o `test -f 'Quad_FIO.cc' || echo './'`Quad_FIO.cc
> > mv -f .deps/apl-Quad_DLX.Tpo .deps/apl-Quad_DLX.Po
> > g++ -DHAVE_CONFIG_H -I. -I..    -Wall -Wno-array-bounds -Werror     -rdynamic 
> > -g -O2 -MT apl-Quad_FX.o -MD -MP -MF .deps/apl-Quad_FX.Tpo -c -o apl-Quad_FX.o 
> > `test -f 'Quad_FX.cc' || echo './'`Quad_FX.cc
> > mv -f .deps/apl-Quad_CR.Tpo .deps/apl-Quad_CR.Po
> > g++ -DHAVE_CONFIG_H -I. -I..    -Wall -Wno-array-bounds -Werror     -rdynamic 
> > -g -O2 -MT apl-Quad_RL.o -MD -MP -MF .deps/apl-Quad_RL.Tpo -c -o apl-Quad_RL.o 
> > `test -f 'Quad_RL.cc' || echo './'`Quad_RL.cc
> > mv -f .deps/apl-Quad_RL.Tpo .deps/apl-Quad_RL.Po
> > g++ -DHAVE_CONFIG_H -I. -I..    -Wall -Wno-array-bounds -Werror     -rdynamic 
> > -g -O2 -MT apl-Quad_SQL.o -MD -MP -MF .deps/apl-Quad_SQL.Tpo -c -o 
> > apl-Quad_SQL.o `test -f 'Quad_SQL.cc' || echo './'`Quad_SQL.cc
> > Quad_SQL.cc:27:25: fatal error: apl-sqlite.hh: No such file or directory
> >  #include "apl-sqlite.hh"
> >                          ^
> > compilation terminated.
> >
> >
> > I had to manually prepend "sql/"
> > to this #include and the 2 other following.
> >
> > after that, it compile fine and seam to run fine too.
> >
> > #include "sql/apl-sqlite.hh"
> > #include "sql/Connection.hh"
> > #include "sql/Provider.hh"
> >
> >
> >
> >
> > Xtian.
> >
> >
> >
> > On 2017-01-11 11:08, Juergen Sauermann wrote:
> > > Hi,
> > >
> > > the warnings should be fixed now, *SVN 844*.
> > >
> > > The warning on raspberry pi:
> > >
> > > *Shape.hh: In member function ‘virtual Token Bif_F12_FORMAT::eval_B(Value_P)’: 
> > > **
> > > **Shape.hh:125:18: error: array subscript is below array bounds 
> > > [-Werror=array-bounds] **
> > > **         if (rho[r])   { volume /= rho[r];  rho[r] = sh;  volume *= rho[r]; } 
> > > **
> > > **                  ^ **
> > > **Shape.hh:126:30: error: array subscript is below array bounds 
> > > [-Werror=array-bounds] **
> > > **         else          { rho[r] = sh;   recompute_volume();                 } 
> > > } **
> > > **                              ^ *
> > >
> > > seems to be entirely bogus. I have checked all occurrences of 
> > > *Shape::set_shape_item()*, including
> > > all inlined functions in *Shape.hh* using *Shape::set_shape_item()*, in the 
> > > functions mentioned, and I
> > > could not find any reason while the compiler came to that conclusion. 
> > > Unfortunately the compiler did
> > > not bother to tell at which line number this happens.
> > >
> > > I also updated FILE_IO.apl as proposed.
> > >
> > > /// Jürgen
> > >
> > >
> > >
> > > On 01/11/2017 06:47 AM, David B. Lamkins wrote:
> > > > There's one remaining when compiling 843 under clang. The attached patch fixes 
> > > > that as well as the remaining error reported by gcc.
> > > >
> > > >
> > > >
> > > > On Tue, Jan 10, 2017 at 03:54:36PM -0800, David Lamkins wrote:
> > > > > Worth noting: There are now no warnings or notes when compiling under gcc 6.3.1.
> > > > >
> > > > > On Tue, Jan 10, 2017 at 3:45 PM, David Lamkins <address@hidden> wrote:
> > > > > > Thank you, Juergen.
> > > > > >
> > > > > > SVN 843 compiles under gcc 6.3.1.
> > > > > >
> > > > > > This is the sole remaining error when compiling with clang 3.8.0:
> > > > > >
> > > > > > clang++ -DHAVE_CONFIG_H -I. -I..    -Werror -Wall -Wno-strict-aliasing
> > > > > > -Wno-deprecated-declarations -I/usr/include -I sql  -I/usr/include -I
> > > > > > sql   -g -O2 -MT apl-UserFunction_header.o -MD -MP -MF
> > > > > > .deps/apl-UserFunction_header.Tpo -c
> > > > > >  -o apl-UserFunction_header.o `test -f 'UserFunction_header.cc' ||
> > > > > > echo './'`UserFunction_header.cc
> > > > > > Tokenizer.cc:604:42: error: explicitly assigning value of variable of
> > > > > > type 'APL_Float' (aka 'double') to itself [-Werror,-Wself-assign]
> > > > > >         if (!imag_need_float)   imag_flt = imag_flt;
> > > > > >                                 ~~~~~~~~ ^ ~~~~~~~~
> > > > > > Tokenizer.cc:637:45: error: explicitly assigning value of variable of
> > > > > > type 'APL_Float' (aka 'double') to itself [-Werror,-Wself-assign]
> > > > > >         if (!imag_need_float)   degrees_flt = degrees_flt;
> > > > > >                                 ~~~~~~~~~~~ ^ ~~~~~~~~~~~
> > > > > > 2 errors generated.
> > > > > >
> > > > > >
> > > > > > On Tue, Jan 10, 2017 at 11:54 AM, Juergen Sauermann
> > > > > > <address@hidden> wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I believe that I fixed most warnings, *SVN 842*.
> > > > > > >
> > > > > > > Since there were many warnings and from different sources, I might have
> > > > > > > overlooked
> > > > > > > some of them (or introduced new ones). Please keep reporting them.
> > > > > > >
> > > > > > > /// Jürgen
> > > > > >
> > > > > >
> > > > > > --
> > > > > > "I think as musicians, we have more vision than we credit ourselves
> > > > > > for. We should dive into it without reserve, and take the sort of
> > > > > > risks it takes to be divisive and impactful. Things have yet to be
> > > > > > done."
> > > > > >    Aaron Fowler Clark
> > > > > >
> > > > > > "Do not seek to follow in the footsteps of the masters. Seek what they sought."
> > > > > >    Matsuo Basho
> > > > > >
> > > > > > "Knowledge speaks; wisdom listens."
> > > > > >    Jimi Hendrix
> > > > > >
> > > > > > http://soundcloud.com/davidlamkins
> > > > > > http://reverbnation.com/lamkins
> > > > > > http://reverbnation.com/lcw
> > > > > > http://lamkins-guitar.com/
> > > > > > http://lamkins.net/
> > > > > > http://successful-lisp.com/
> > > > >
> > > > >
> > > > > --
> > > > > "I think as musicians, we have more vision than we credit ourselves
> > > > > for. We should dive into it without reserve, and take the sort of
> > > > > risks it takes to be divisive and impactful. Things have yet to be
> > > > > done."
> > > > >    Aaron Fowler Clark
> > > > >
> > > > > "Do not seek to follow in the footsteps of the masters. Seek what they sought."
> > > > >    Matsuo Basho
> > > > >
> > > > > "Knowledge speaks; wisdom listens."
> > > > >    Jimi Hendrix
> > > > >
> > > > > http://soundcloud.com/davidlamkins
> > > > > http://reverbnation.com/lamkins
> > > > > http://reverbnation.com/lcw
> > > > > http://lamkins-guitar.com/
> > > > > http://lamkins.net/
> > > > > http://successful-lisp.com/