[bongo-devel] Re: Display track lengths in playlist buffers (suggested by Romain Francoise)

[Daniel Jensen]

[I moved this discussion from -patches.]

Daniel Brockman <address@hidden> writes:

> address@hidden (Daniel Jensen) writes:
>
>> In `bongo-default-infoset-from-file-name', the `bongo-track-length'
>> variable is sometimes unbound.
>
> Thank you, I applied this.
>
> Maybe for clarity (and to avoid compiler warnings) we should
> defvar all those dynamically bound variables.

Maybe, though the others are documented well and they are only used at
runtime. Besides `bongo-track-length', there are only warnings for a few
defvar'ed variables -- they can be moved up in the file.

For `bongo-track-length', it is only used in one place. Do you think it
would be better to remove it from `bongo-default-infoset-from-file-name'
and do something like this in `bongo-file-track-infoset'?

  (let ((infoset (bongo-infoset-from-file-name (bongo-line-file-name point)))
        (track-length (bongo-line-get-property 'bongo-track-length point)))
    (when track-length
      (setcdr (cdr (assoc 'track infoset)) `((length . ,track-length))))
    infoset)

It looks like it could work.