[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bongo-devel] Re: VLC and audio CD's
From: |
Daniel Brockman |
Subject: |
Re: [bongo-devel] Re: VLC and audio CD's |
Date: |
Wed, 04 Apr 2007 16:44:44 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.92 (gnu/linux) |
address@hidden (Daniel Jensen) writes:
> Daniel Brockman <address@hidden> writes:
>
>> address@hidden (Daniel Jensen) writes:
>>
>>> I wrote earlier that `I' completion would be too much to
>>> type, but I'm not so sure about that anymore. I forgot
>>> that RET completes and exits. You would type `I c RET'
>>> and `I a RET'; not too bad.
>>
>> Cool. Let's do that, then. That'll save us from having to
>> argue about what track type should go on what key, and it'll
>> save users from having to remember it.
>
> I wrote an `I' command:
Cool, thanks!
> (defvar bongo-insertion-commands
> '(("file" . bongo-insert-file)
> ("tree" . bongo-insert-directory-tree)
I changed this to `Directory tree', because I figured the
added clarity will be worth more than being able to choose
this with a minimum number of keystrokes, since normally you
would not use this command to insert directory trees.
> ("directory" . bongo-insert-directory)
> ("uri" . bongo-insert-uri)
> ("cd" . bongo-insert-cd)
> ("action" . bongo-insert-action)
> ("playlist" . bongo-insert-playlist-contents))
I added case to all the descriptions (e.g., `URI'),
and used `completion-ignore-case' for convenience.
> "An alist of insertion commands for `bongo-insertion-dispatcher'.")
You should usually elide articles from the start of docstrings.
> ;;; `bongo-insert' is a shorter name, and perhaps better?
> ;;; it is marked as obsolete in bongo.el.
I'd like to use `bongo-insert' for the `i' command.
> (defun bongo-insertion-dispatcher ()
I renamed this to `bongo-insert-special'.
> "Insert an item into the current Bongo buffer.
> Dispatches to other specialized insertion commands. For a list
> of possible items and commands, see `bongo-insertion-commands'."
> (interactive)
> (let ((command (cdr (assoc (completing-read "Insert: "
> bongo-insertion-commands nil t)
> bongo-insertion-commands))))
> (and command (call-interactively command))))
I removed the `(and command ...)' check, because I figured
it should never fail so it's clearer to just let it blow up.
(Let me know if you think this is a mistake.)
Now we just need `i'.
Thanks again,
--
Daniel Brockman <address@hidden>
- [bongo-devel] VLC and audio CD's, Joel Molin, 2007/04/03
- Re: [bongo-devel] VLC and audio CD's, Daniel Brockman, 2007/04/03
- [bongo-devel] Re: VLC and audio CD's, Joel Molin, 2007/04/03
- [bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/04
- Re: [bongo-devel] Re: VLC and audio CD's, Daniel Brockman, 2007/04/04
- [bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/05
- Re: [bongo-devel] Re: VLC and audio CD's, Daniel Brockman, 2007/04/05
- [bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/05
- Re: [bongo-devel] Re: VLC and audio CD's, Daniel Brockman, 2007/04/05
[bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/03