[bongo-devel] Re: Bongo marking and selecting random tracks

[Anthony Chaumas-Pellet]

From: address@hidden (Daniel Jensen)

> The attached patch changes `bongo-randomly-playable-track-line-p' to
> accept marked tracks only, when there are marked tracks around. How
> do you like that suggestion? Is it similar to your idea?

Thanks! Your patch does almost exactly what I want with far less work,
so my own function is obsolete.

The one problem at present is that the track currently playing can be
picked when choosing a new track (at least when I explicitly ask for a
new random track). A quick fix is to also check against
(not (bongo-currently-playing-track-line-p)).

This 'random choice picks same track' behaviour seems specific to
'random-marked', as it doesn't appear when no tracks are marked. So,
the above call can probably be added to
'bongo-randomly-playable-track-line-p', giving the attached patch.

Thanks again!
Anthony Chaumas-Pellet

@@ -5998,7 +5993,10 @@
 Inspect the line at POINT; or the one at point, if POINT is nil.
 Currently, the only non-randomly-playable tracks are action tracks."
   (and (bongo-track-line-p point)
-       (not (bongo-action-track-line-p point))))
+       (not (bongo-action-track-line-p point))
+       (not (bongo-currently-playing-track-line-p))
+       (or (null bongo-marked-track-line-markers)
+           (bongo-marked-track-line-p point))))
 
 (defun bongo-unplayed-randomly-playable-track-line-p (&optional point)
   "Return non-nil for unplayed and randomly playable track lines.