Re: Patch for Bison 3.1 and VC2015

[Akim Demaille]

> Le 29 sept. 2018 à 01:53, Paul Eggert <address@hidden> a écrit :
> 
> On 9/28/18 7:26 AM, Simon Sobisch wrote:
>>    As I was told that only "current" VC compilers are considered for being
>>    patched I've tried to compile Bison 3.1 with VC 2015.
>>    Two places needed a patch to allow all sources to be compiled.
>>    You find a patch file attached.
> 
> 
> Thanks for the heads-up. I installed the attached patches, which attempt to 
> fix the problems you mention in more-portable ways. Please give them a try.

Joel’s trick for UNIQSTR_CONCAT was amazing :)  Out of curiosity,
why didn’t you use alloca?

And the setlocale part comes from

commit d740d2b541dff1d94d78bf6c5f38e7c6a34b036a
Author: Akim Demaille <address@hidden>
Date:   Fri Aug 31 18:18:13 2012 +0200

and includes

+      fputs (_("General help using GNU software: "
+               "<http://www.gnu.org/gethelp/>.\n"),
+             stdout);
+      /* Don't output this redundant message for English locales.
+         Note we still output for 'C' so that it gets included in the
+         man page.  */
+      const char *lc_messages = setlocale (LC_MESSAGES, NULL);

So Bison was using declarations after statements since 2012…
First included in Bison 2.6.4.