[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: avoid compiler warnings
From: |
Eric Blake |
Subject: |
Re: avoid compiler warnings |
Date: |
Tue, 30 Jun 2009 05:57:41 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Akim Demaille on 6/29/2009 8:55 AM:
>> I'm not sure why the messages are off by one (the lines I touched were
>> 537 and
>> 591); maybe the #line directive generation needs to be investigated?
>
> Yep, indeed.
>
>> Also, I'm seeing a spurious diff on parse-gram.c which points to
>> compilation
>> with a user-specific setup;
>
> yes, this is painful. I'll workout a wrapper to avoid this.
I'll let you deal with those.
>> OK to apply this patch?
>
> yes please.
>
>> I only tested the master branch, might it also be
>> needed on other branches?
>
> Yep, branch-2.5.
Applied to branch-2.5, then cherry-picked into master.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkpJ/bUACgkQ84KuGfSFAYCRGQCg0Lu4fTrubITZ/6Pk7MKtnt6k
cDsAn0aSeM5MJTF3mB0FuHPfzZ06Fs5Z
=ztGn
-----END PGP SIGNATURE-----