[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: #if versus #ifdef in bison.simple
From: |
Akim Demaille |
Subject: |
Re: #if versus #ifdef in bison.simple |
Date: |
05 Dec 2001 09:32:16 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Civil Service) |
>>>>> "Paul" == Paul Eggert <address@hidden> writes:
>> From: Akim Demaille <address@hidden> Date: 30 Nov 2001 12:30:21
>> +0100
>>
>> Just one note: we try as much as possible to move to #if instead of
>> #ifdef. In particular, you should safely rely on #if ERROR_VERBOSE
>> and so on.
Paul> I like that style for code that I maintain, but bison.simple
Paul> needs to follow a stricter style, as it is used by people who
Paul> use a variety of styles. A few people like to compile with gcc
Paul> -Wundef, and that will cause `#if FOO' to generate a diagnostic
Paul> if FOO is not defined.
I agree. I was referring to redefining YYERROR_VERBOSE to 1 if it was
only defined.