Re: [Ayttm-commits] CVS: ayttm/modules/msn2 msn.C,1.84,1.85

[Philip S Tellis]

Sometime Today, Colin Leroy <address@hidden> assembled some asciibets to say:

>       if(stat(file, &stats) < 0) {
> -             do_error_dialog("Could not read file", "Error");
> +             do_error_dialog("File is not readable.", "Error");

I think "Could not read file" is more understandable by the user, also, 
it takes the blame for the error rather than blaming the file (File is 
not readable).  If you choose the latter, then it should be File is 
unreadable.

I think I should get started on that HCI stuff soon.

>    char dialog_message[1025];
>    char *tmp = Utf8ToStr(friendlyname);
> -  sprintf(dialog_message, _("The MSN user %s (%s) would like to speak with 
> you using (Gnome|Net)Meeting.\nDo you want to accept ?"),
> +  sprintf(dialog_message, _("The MSN user %s (%s) would like to speak with 
> you using (Gnome|Net)Meeting.\n\nDo you want to accept ?"),

This looks like a potential buffer overflow.  dialog_message is 1025 
bytes, but tmp and from could potentially make it larger - especially if 
someone is trying to do it on purpose.

Philip