RE: [Axiom-developer] sman and X libraries

[Page, Bill]

On Wednesday, November 22, 2006 8:26 PM I wrote:

> Waldek Hebisch wrote:
> > in version 288 I see:
> > 
> > 2006-11-18  Bill Page  <address@hidden>
> > 
> >        * Makefile.pamphlet (LDFLAGS): Add X11 libraries flags.
> >        * Makefile.in: Regenerate.
> > 
> > Why do we need this: AFAIK sman should not use any X libraries.
> > In recent build 'ldd sman' gives me:
> > 
> >         libXpm.so.4 => /usr/X11R6/lib64/libXpm.so.4 
> > (0x0000002a9566c000)
> >         libSM.so.6 => /usr/X11R6/lib64/libSM.so.6 
> (0x0000002a95780000)
> >         libICE.so.6 => /usr/X11R6/lib64/libICE.so.6 
> > (0x0000002a9588d000)
> >         libX11.so.6 => /usr/X11R6/lib64/libX11.so.6 
> > (0x0000002a959af000)
> >         libc.so.6 => /lib/libc.so.6 (0x0000002a95bc4000)
> >         libXext.so.6 => /usr/X11R6/lib64/libXext.so.6 
> > (0x0000002a95dea000)
> >         libXau.so.6 => /usr/X11R6/lib64/libXau.so.6 
> > (0x0000002a95efe000)
> >         libXdmcp.so.6 => /usr/X11R6/lib64/libXdmcp.so.6 
> > (0x0000002a96001000)
> >         libdl.so.2 => /lib/libdl.so.2 (0x0000002a96104000)
> >         /lib64/ld-linux-x86-64.so.2 (0x0000002a95556000)
> > 
> > so now sman will refuse to run on a machine without X libraries.
> > 
> > -- 
> 
> I think this change:
> 
http://axiom.svn.sourceforge.net/viewvc/axiom/branches/build-improvement
s/src/sman/Makefile.in?view=diff&pathrev=288&r1=287&r2=288
> 
> is not correct. The patch I sent to Gaby is here:
> 
http://lists.nongnu.org/archive/html/axiom-developer/2006-09/msg00297.ht
ml
> 
> includes the line:
> 
> +LDFLAGS= -L${LIB} -lspad ${LDF} -lspad ${AXIOM_X11_LDFLAGS}
> 
> and
> 
>  <<sman>>=
>  ${OUT}/sman: ${SMANOBJS} ${MIDOBJ}/sman.o
>         @ echo 13 linking sman
> -       @ ${CC} -o ${OUT}/sman ${MIDOBJ}/sman.o ${SMANOBJS}
> +       @ ${CC} -o ${OUT}/sman ${MIDOBJ}/sman.o ${SMANOBJS} ${LDFLAGS}
> 
> but in fact ${AXIOM_X11_LDFLAGS} is not needed for sman.
> 
> I think we need a more "delicate" approach to providing the right
> libraries in the right place, i.e. more autoconf variables.
> 

On linux it seems to be be possible to remove LDFLAGS for sman,
sesseion and spadclient and rebuild the code in this directory
with no problems.

The patch was motivated by building Axiom on a Sun 280R (sparc,
64bit) Solaris 10 system with a GNU toolchain. My recollection
(not so clear now) is that I added LDFLAGS to the compiles
because of some missing dependencies which were satified by
this option. But a lot has changed in build-improvements since
then. I recently tried to repeat the build on the Sun with a
newer revision but failed and ran out of time.

I think the best thing is to remove the LDFLAGS like this:

address@hidden sman]$ pwd
/home/page/axiom.build-improvements/src/sman
address@hidden sman]$ svn diff *
Index: Makefile.pamphlet
===================================================================
--- Makefile.pamphlet   (revision 301)
+++ Makefile.pamphlet   (working copy)
@@ -65,7 +65,7 @@
 \section{session}
 <<session>>=
 ${OUTLIB}/session: $(session_objects) $(session_DEPENDENCIES)
-       $(CC) $(session_objects) -o $@ $(session_LDADD) $(LDFLAGS) -o $@
+       $(CC) $(session_objects) -o $@ $(session_LDADD) -o $@
 @

 \section{nagman}
@@ -73,13 +73,13 @@
 necessary code (for instance, [[callnag]]).
 <<nagman>>=
 ${OUT}/nagman: $(nagman_objects) $(nagman_DEPENDENCIES)
-       $(CC) $(nagman_objects) -o $@ $(nagman_LDADD) $(LDFLAGS)
+       $(CC) $(nagman_objects) -o $@ $(nagman_LDADD)
 @

 \section{spadclient}
 <<spadclient>>=
 ${OUTLIB}/spadclient: $(spadclient_objects) $(spadclient_DEPENDENCIES)
-       $(CC) $(spadclient_objects) $(spadclient_LDADD) $(LDFLAGS) -o $@
+       $(CC) $(spadclient_objects) $(spadclient_LDADD) -o $@

 spadclient.o: ${INC}/useproto.h ${INC}/spadclient.H1
 @
@@ -87,7 +87,7 @@
 \section{sman}
 <<sman>>=
 ${OUT}/sman: $(sman_objects) $(sman_DEPENDENCIES)
-       $(CC) $(sman_objects) $(sman_LDADD) $(LDFLAGS) -o $@
+       $(CC) $(sman_objects) $(sman_LDADD) -o $@

 $(sman_objects): sman.h

address@hidden sman]$

-----

Then when I have more time (or Gaby) we can resolve the problem
with building on Sun a slightly different way.

Regards,
Bill Page.