Re: [Axiom-developer] wrong exit status in build-improvements

[Gabriel Dos Reis]

Waldek Hebisch <address@hidden> writes:

| > Waldek Hebisch <address@hidden> writes:
| > 
| > | Current "Standard boilerplate dependencies" give spurious failure. 
| > | This is caused by the last test commad in $(RECURSIVE_TARGETS).
| > | The following fixed problem for me:
| > | 
| > | 
| > | --- config/setup-dep.mk   (wersja 182)
| > | +++ config/setup-dep.mk   (kopia robocza)
| > | @@ -35,7 +35,7 @@
| > |   done; \
| > |   if test "$$dot_seen" = "no"; then \
| > |      $(ENV) $(MAKE) "$$target-ax" || exit 1; \
| > | - fi; test -z "$$failcmd"
| > | + fi
| > 
| > Why do you think that is bogus?
| > (That is what Automake generates for me.)
| > 
| > -- Gaby
| > 
| 
| man test:
| ....
| 
|        -z STRING
|               the length of STRING is zero
| .....
| 
| At the beginning we have:
| 
|         failcmd='exit 1'; 
| 
| On normal path (without -k option) there is no assignment to failcmd,
| so the test fails and gives exit status 1. 

The real fix, is to test for $$fail, NOT $$failcmd.  Notice fail is
set when --keep is specified.

-- Gaby