avrdude-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[avrdude-dev] [patch #8380] adds 500k 1M 2M baud to ser_posix.c


From: Joerg Wunsch
Subject: [avrdude-dev] [patch #8380] adds 500k 1M 2M baud to ser_posix.c
Date: Wed, 12 Mar 2014 11:23:57 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0

Follow-up Comment #8, patch #8380 (project avrdude):

Thank you for the patch!

Some remarks:

. I don't think you have to special-case OSX in any way.  It does
  already work the way it is now, just the same like *BSD (which it is
  derived from in that respect); the Bxxxx names are just aliases for
  number xxxx there, so cfsetispeed() and cfsetospeed() can be fed the
  raw baudrate numbers as well as the Bxxxx defines.

. Your patch for Linux is probably fine, though I cannot test it
  (lacking any device with a non-standard baudrate).

. Please don't add unrelated changes to a patchfile (indentation
  changes in line 96 ff.).


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?8380>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]