Re: make check failures

[Alexandre Duret-Lutz]

>>> "Patrick" == Patrick Welche <address@hidden> writes:

[...]

 >> env TESTS='gnits2.test gnits3.test obsolete.test' VERBOSE=x make -e check

 Patrick> .. and here it is.

Thanks.  I'm installing the following patch.  It should fix
these three failures.  

The gnits2 and gnits3 failures show a difference between GNU
make and BSD make when run with the `-k' option: GNU make will
reflect whether it encountered an error in it's exit status
while BSD make will always succeed.  I've submitted a separate
patch to document this in the Autoconf manual.

2002-07-24  Alexandre Duret-Lutz  <address@hidden>

        Fix failures reported by Patrick Welche on NetBSD.
        * tests/gnits2.test, tests/gnits3.test: Don't trust the exit
        status of `make -k'.
        * tests/obsolete.test: Source obs.1 and obs.2 from current
        directory.

Index: tests/gnits2.test
===================================================================
RCS file: /cvs/automake/automake/tests/gnits2.test,v
retrieving revision 1.2
diff -u -r1.2 gnits2.test
--- tests/gnits2.test   20 Jul 2002 15:48:35 -0000      1.2
+++ tests/gnits2.test   24 Jul 2002 21:41:56 -0000
@@ -73,7 +73,7 @@
 $MAKE install
 test -f ../inst-dir/bin/pfine
 test ! -f ../inst-dir/bin/fine
-$MAKE -k installcheck 2>stderr && exit 1
+$MAKE -k installcheck 2>stderr || : # Never trust the exit status of make -k.
 cat stderr
 grep 'pfubar does not support' stderr
 grep 'pfubar3 does not support' stderr
Index: tests/gnits3.test
===================================================================
RCS file: /cvs/automake/automake/tests/gnits3.test,v
retrieving revision 1.1
diff -u -r1.1 gnits3.test
--- tests/gnits3.test   22 Jul 2002 17:00:44 -0000      1.1
+++ tests/gnits3.test   24 Jul 2002 21:41:56 -0000
@@ -62,7 +62,7 @@
 ../configure --prefix=`pwd`/../inst-dir --program-prefix=p
 $MAKE
 $MAKE install
-$MAKE -k installcheck 2>stderr && exit 1
+$MAKE -k installcheck 2>stderr || : # Never trust the exit status of make -k.
 cat stderr
 grep 'sub/pnok does not support' stderr
 grep 'sub/pnok.sh does not support' stderr
Index: tests/obsolete.test
===================================================================
RCS file: /cvs/automake/automake/tests/obsolete.test,v
retrieving revision 1.7
diff -u -r1.7 obsolete.test
--- tests/obsolete.test 19 Jul 2002 20:17:59 -0000      1.7
+++ tests/obsolete.test 24 Jul 2002 21:41:56 -0000
@@ -21,10 +21,10 @@
 
 # Expect Autoconf to complain about each of the macros in obs.
 $AUTOCONF -Wobsolete >stderr 2>&1
-. obs.1
+. ./obs.1
 # Make sure Autoupdate remove each of these macros.
 $AUTOUPDATE || exit 1
-. obs.2
+. ./obs.2
 
 # Autoconf should be able to grok the updated configure.in.
 $AUTOCONF || exit 1

-- 
Alexandre Duret-Lutz