Re: BTW: This is not the last problem

[Richard Boulton]

Executive summary: this is a KDE problem, not an automake problem.

The problem is with the am_edit script: it doesn't understand the
backslash-end-of-line line continuations.

Specifically, in noteedit/icons/Makefile.am, data_ICON is defined
as a set of lines joined by \-newlines.  These is passed through into
the Makefile.in, and then am_edit reads this, and splits it into entries
by whitespace.  The \-newlines are thus accidentally included into the
entreies.  The following situation causes problems:

... \
perccross

- an entry "\perccross" is extracted, rather than "percross".


The problem is hidden in a lot of cases because many of the entries in
data_ICON are duplicated elsewhere (in the middle of a line)

I assume that it worked in automake 1.4 because automake 1.4 rewrote the
definition of data_ICON slightly such that the bug didn't fire.

The correct solution is to fix am_edit so that it understands \-newline.

A workaround is to start each line of the definition of data_ICON with a
newline, and ensure that there is a space before the \ at the ends of
all lines.

On Thu, 2002-04-25 at 11:03, Joerg Anders wrote:
> BTW: The am_edit is not the last problem.
> 
> automake > 1.4 (i.e. automake-1.5, automake-1.6, automake-1.6.1 ,excludes 
> some pixmaps from
> installation (perhaps they don't look good ;-)
> 
> Of course I cannot say whether this is a KDE or
> automake or autoconf problem. All I know is till
> automake-1.4 the following worked:
> 
> In "icons" directory:
> 
> $ cat Makefile.am
> data_ICON = 128thnote 32ndnote 64thnote beamednote cleficon cross dottednote \
> ...  perccross  ... repopenclose ... tinyeight ...
> 
> $ make -f admin/Makefile.common (that is "aclocal", "automake")
> 
> in "icons" directory:
> 
> $ cat Makefile.in
>   ...
> install-kde-icons:
>  $(INSTALL_DATA) $(srcdir)/hi32-action-128thnote.png 
> $(DESTDIR)$(datadir)/hicolor/32x32/actions/128thnote.png
>  $(INSTALL_DATA) $(srcdir)/hi32-action-128thnote.png 
> $(DESTDIR)$(datadir)/hicolor/32x32/actions/128thnote.png
> 
> ....
> 
> and so on , but there is no:
> 
> $(INSTALL_DATA) $(srcdir)/hi32-action-perccross.png ...
> ..
> $(INSTALL_DATA) $(srcdir)/hi32-action-repopenclose.png ...
> ..
> $(INSTALL_DATA) $(srcdir)/hi32-action-tinyeight.png ...
> ..
> 
> And I can't see any speciality concerning these 3 icons.
> 
> All I can say: I downgraded to automake-1.4: All works (besides the English 
> tips)
> 
> If you like you can download the example from:
> 
> http://rnvs.informatik.tu-chemnitz.de/automakeerror/automakeerror.html
> tar -xvzf nnn1.tgz
> cd noteedit-1.18.3a
> make -f admin/Makefile.common
> cd noteedit/icons
> $ cat Makefile.am
> data_ICON = 128thnote 32ndnote 64thnote beamednote cleficon cross dottednote \
> ...  perccross  ... repopenclose ... tinyeight ...
> 
> $ cat Makefile.in
>   ...
> install-kde-icons:
>  $(INSTALL_DATA) $(srcdir)/hi32-action-128thnote.png 
> $(DESTDIR)$(datadir)/hicolor/32x32/actions/128thnote.png
>  $(INSTALL_DATA) $(srcdir)/hi32-action-128thnote.png 
> $(DESTDIR)$(datadir)/hicolor/32x32/actions/128thnote.png
> 
> ....
> 
> 
> As you can see perccross, repopenclose and tinyeight is excluded from 
> installation.(?)
> 
> 
> -- 
> J.Anders, Chemnitz, GERMANY (address@hidden)
> 
> 
>