[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 37-unify-handle-dist.patch

From: Tom Tromey
Subject: Re: 37-unify-handle-dist.patch
Date: 20 Feb 2001 13:02:50 -0700

>>>>> "Akim" == Akim Demaille <address@hidden> writes:

Akim>   * Remove, merge into...
Akim>   * here.  Use the neat sed snippet for banners.
Akim>   BTW, distcheck is phony.
Akim>   * (&handle_dist_worker): Remove, merge into...
Akim>   (&handle_dist): this.
Akim>   (&file_contents): Strip leading new lines.
Akim>   Be sure to end comments with new lines.


BTW it is hard to read big rearrangement patches.  It is made worse
because sometimes they include actual code changes as well.  For
instance this patch wasn't just a rearrangement, it included semantic
differences in file_contents.

I'd prefer to see rearrangements separate from semantic changes.  Then
hopefully I can approve rearrangements without trying to read them in


reply via email to

[Prev in Thread] Current Thread [Next in Thread]