automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/10] depend: assume we can always pass '-o' to the C compil


From: Stefano Lattarini
Subject: Re: [PATCH 03/10] depend: assume we can always pass '-o' to the C compiler
Date: Tue, 14 May 2013 12:59:45 +0200

Hi Peter.

On 05/14/2013 12:33 PM, Peter Rosin wrote:
> On 2013-05-14 10:04, Stefano Lattarini wrote:
>> diff --git a/bin/automake.in b/bin/automake.in
>> index 63e5962..df6560d 100644
>> --- a/bin/automake.in
>> +++ b/bin/automake.in
>> @@ -1330,7 +1324,7 @@ sub handle_languages ()
>>  
>>                           COMPILE   => '$(' . $lang->compiler . ')',
>>                           LTCOMPILE => '$(LT' . $lang->compiler . ')',
>> -                         -o        => $output_flag);
>> +                        );
>>      }
>>  
>>      # Now include code for each specially handled object with this
> 
> The remaining trailing comma looks bad on the LTCOMPILE line. It's
> probably benign, but...
>
Yes, it is.  In fact, it is deliberate, so that if want to add a new
transform to the list we'll just need to insert it on a new line,
without also having to edit the line of the LTCOMPILE transform to
add a trailing comma to it.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]