[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] compile: avoid AC_PROG_CC messy rewrite
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 01/11] compile: avoid AC_PROG_CC messy rewrite |
|
Date: |
Mon, 14 Jan 2013 13:26:08 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/12/2013 05:51 AM, Stefano Lattarini wrote:
> Instead, only touch up AC_PROG_CC to distribute the 'compile' script and
> to rewrite $CC if a losing compiler is detected.
That reads poorly - I first parsed it as "if losing compiler, then
(distribute the 'compile' script and rewrite $CC)"; when you really
intend "always distribute 'compile' script, and (if losing compiler,
rewrite $CC)". Try this wording:
Instead, just touch up AC_PROG_CC to rewrite $CC when a losing compiler
is detected, and to always distribute the 'compile' script.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [PATCH 00/11] Make 'subdir-objects' mandatory, and related cleanups, Stefano Lattarini, 2013/01/12
- [PATCH 05/11] depend: assume '-c' compiler flag always means to produce object files, Stefano Lattarini, 2013/01/12
- [PATCH 01/11] compile: avoid AC_PROG_CC messy rewrite, Stefano Lattarini, 2013/01/12
- Re: [PATCH 01/11] compile: avoid AC_PROG_CC messy rewrite,
Eric Blake <=
- [PATCH 04/11] depend: assume we can always pass "-o" to the C compiler, Stefano Lattarini, 2013/01/12
- [PATCH 03/11] cleanup: having subdir-objects mandatory allow us some simplifications, Stefano Lattarini, 2013/01/12
- [PATCH 06/11] Automake::Language: drop unused fields 'compile_flag' and 'output_flag', Stefano Lattarini, 2013/01/12
- [PATCH 02/11] subdir-objects: enable unconditionally, Stefano Lattarini, 2013/01/12
- [PATCH 09/11] depend2.am: reduce code duplication, Stefano Lattarini, 2013/01/12
- [PATCH 10/11] depend: prefer $(...) over `...` in Cygwin-specific recipes, Stefano Lattarini, 2013/01/12
- [PATCH 07/11] depend2.am: refactor and remove code duplication, Stefano Lattarini, 2013/01/12
- [PATCH 11/11] depend: reduce code duplication, de-uglify make verbose output, Stefano Lattarini, 2013/01/12
- [PATCH 08/11] depend2.am: preparatory refactoring, Stefano Lattarini, 2013/01/12