Re: [PATCH] {master} tags: unify recursion for tags targets with that of "usual" targets

[Stefano Lattarini]

On 07/22/2012 11:31 AM, Stefano Lattarini wrote:
> This change has a side effect: now any failure of the 'tags', 'ctags',
> 'cscope' and 'cscopelist' targets in a subdirectory will cause the
> recursive command issued from the top directory to fail.  We believe
> that this behavioural change is not only justified by the simplification
> this patch entails, but actually offers better semantics: ignoring
> failures by default is never a good idea, and with make, the user can
> anyway order the completion of commands in the face of possible failures
> with the '-k' option.
> 
> * NEWS: Update.
> * automake.in (%required_targets): Add keys 'cscopelist-am', 'tags-am'
> and 'ctags-am'.
> (handle_tags): Greatly simplified, the major part of the handling of
> recursion for the 'tags', 'ctags' and 'cscopelist' now moved out to ...
> * lib/am/tags.am: ... this file, that has been adjusted and extended
> accordingly.
> * t/maken3.sh: Remove testing of the 'TAGS' target, that is now just
> an alias to 'tags'.  Without this change, this test would spuriously
> fail.
> 
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
>  
>  I originally found this simplification while working on Automake-NG,
>  but I think it is worth to also apply it to mainline Automake.  Any
>  objection?  Otherwise I will apply in 48 hours or so.
>
>  NEWS           |    4 +++
>  automake.in    |   83 
> ++++++++++++++------------------------------------------
>  lib/am/tags.am |   50 +++++++++++++++++++---------------
>  t/maken3.sh    |   10 +++----
>  4 files changed, 56 insertions(+), 91 deletions(-)
>
Pushed.

Regards,
  Stefano