automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/8] tags: new var $(am__tagged_files) to list all files to r


From: Stefano Lattarini
Subject: Re: [PATCH 3/8] tags: new var $(am__tagged_files) to list all files to run taggers on
Date: Fri, 08 Jun 2012 21:27:07 +0200

On 06/08/2012 10:20 AM, Stefano Lattarini wrote:
> This change reduce code duplication a little, and will be needed by
> future simplifications.
> 
> * automake.in (handle_tags): Define a new 'am__tagged_files' private
> make variable that lists all files to run taggers (mkid, cscope, ctags,
> etc) on.
> * lib/am/tags.am: Use it in several recipes and dependencies list to
> reduce code duplication.
> 
Hmpf, this patch uselessly kept some duplicated code; consider the hunk
below squashed in, which should solve the issue.

Sorry for the noise,
  Stefano

-*-*-*-

diff --git a/automake.in b/automake.in
index cd3d7bc..864f70f 100644
--- a/automake.in
+++ b/automake.in
@@ -3667,18 +3667,6 @@ sub handle_tags
        || var ('ETAGS_ARGS')
        || @tag_deps)
     {
-       my @config;
-       foreach my $spec (@config_headers)
-       {
-           my ($out, @ins) = split_config_file_spec ($spec);
-           foreach my $in (@ins)
-             {
-               # If the config header source is in this directory,
-               # require it.
-               push @config, basename ($in)
-                 if $relative_dir eq dirname ($in);
-             }
-       }
        $output_rules .= &file_contents ('tags',
                                         new Automake::Location,
                                         CONFIG    => "@config",



reply via email to

[Prev in Thread] Current Thread [Next in Thread]